Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cookiecutter to integration standards #919

Merged
merged 1 commit into from
Aug 25, 2024
Merged

Conversation

erikzaadi
Copy link
Member

  • Proper .env.example files
  • Update vscode launch configuration with new generated integration
  • Add initial static examples to see the integration quickly in Port,
    including example blueprints and mappings
  • Add unit test stub

Description

Update the cookiecutter template for new integrations with integration standards.

In addition, make it simpler to start developing an integration with a "working" sample out of the box.

Type of change

Please leave one option from the following and delete the rest:

  • Non-breaking change (fix of existing functionality that will not change current behavior)

@erikzaadi erikzaadi requested a review from a team as a code owner August 21, 2024 11:32
@erikzaadi erikzaadi force-pushed the PORT-9072-cookiecutter branch 4 times, most recently from c2dd61b to 688ac66 Compare August 22, 2024 12:22
Copy link
Member

@matan84 matan84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments

port_ocean/config/settings.py Outdated Show resolved Hide resolved
port_ocean/cli/commands/new.py Show resolved Hide resolved
* Proper `.env.example` files
* Update vscode launch configuration with new generated integration
* Add initial static examples to see the integration quickly in Port,
  including example blueprints and mappings
* Add unit test stub
Copy link
Member

@matan84 matan84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erikzaadi erikzaadi merged commit 2b7377c into main Aug 25, 2024
12 checks passed
@erikzaadi erikzaadi deleted the PORT-9072-cookiecutter branch August 25, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants