[Core] Fix unpacking issue in unregister raw function #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mk-armah
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix unpacking error in unregister raw:
What - Resolved an issue in the
unregister_rawmethod where an incorrect unpacking operation was causing aValueError ("not enough values to unpack (expected 2, got 1)").Why - This error occurred because the method was incorrectly expecting a tuple of entities and errors from the asyncio.gather call, but only receiving a single list due to the absence of zip unpacking.
How -The fix involved using zip to correctly unpack the results into entities and errors, and then flattening these lists to handle multiple resource mappings properly. This change ensures that the method correctly processes the output of the asynchronous tasks and handles errors appropriately.
Type of change
Please leave one option from the following and delete the rest:
Screenshots
Include screenshots from your environment showing how the resources of the integration will look.
API Documentation
Provide links to the API documentation used for this integration.