-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Integration][GitLab] - Enable Existing Webhooks on Restarts #1014
Merged
PeyGis
merged 13 commits into
main
from
PORT-10405-bug-gitlab-webhooks-are-getting-disabled-after-integration-restarts
Sep 18, 2024
Merged
[Integration][GitLab] - Enable Existing Webhooks on Restarts #1014
PeyGis
merged 13 commits into
main
from
PORT-10405-bug-gitlab-webhooks-are-getting-disabled-after-integration-restarts
Sep 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matan84
requested changes
Sep 15, 2024
matan84
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…isabled-after-integration-restarts
…er-integration-restarts' of https://github.com/port-labs/ocean into PORT-10405-bug-gitlab-webhooks-are-getting-disabled-after-integration-restarts
Tankilevitch
approved these changes
Sep 18, 2024
PeyGis
deleted the
PORT-10405-bug-gitlab-webhooks-are-getting-disabled-after-integration-restarts
branch
September 18, 2024 17:11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What - We had a bug where GitLab webhooks were disabled on restart. The disablement could also be used by GitLab when the receiving host does not meet their requirement. I updated the logic for creating webhook such that it can re-create existing webhooks when it has been disabled.
Why -
How -
Type of change
Please leave one option from the following and delete the rest:
All tests should be run against the port production environment(using a testing org).
Core testing checklist
Integration testing checklist
examples
folder in the integration directory.Preflight checklist
Screenshots
API Documentation
Delete Hook API
Create Hook API