-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Flatpak manifest #187
Add Flatpak manifest #187
Conversation
This matches the manifest at Flathub, with the following changes: - Bumps FreeDesktop runtime to 22.08 since 20.08 is EOL - Changes the source to point to the current dir instead of the archive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. I think QA should try running and using a flatpak built with this manifest, after which we can merge it.
I haven't had to build a Flatpak locally yet, so I am referencing https://docs.flatpak.org/en/latest/first-build.html I'm not sure if I'm doing something wrong, but I'm getting a failure in the sed line:
I don't really understand the failure though, because |
@leviport the way I would recommend testing this would be to use GNOME Builder (e.g. from Flathub) and open the project. It should prompt you to install any SDKs needed in the environment, then let you one-click build and run it. But I can check what's needed (and maybe add to the README!) to do it all from the CLI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, using Builder seemed to work (just with very long compile times). I was able to build and run Popsicle via Builder, and flashing images to USB devices worked as expected.
This matches the manifest at Flathub, with the following changes:
The reason for adding the manifest in-tree is that it enables using GNOME Builder to one-click build and run Popsicle; this makes it far, far easier for people like me to contribute. 😄