Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite mixer map for TRX40 Aorus Master #167

Merged
merged 1 commit into from
Jul 29, 2022
Merged

Rewrite mixer map for TRX40 Aorus Master #167

merged 1 commit into from
Jul 29, 2022

Conversation

13r0ck
Copy link

@13r0ck 13r0ck commented Jul 28, 2022

This should fix the sound for the mega r1.1 that assembly is trying to ship.

Requires pop-os/alsa-ucm-conf#6

The Aorus Xtreme uses the same ID for audio controller, but the
maps are very different. This successfully fixes all of the
audio jacks on the back.
@13r0ck 13r0ck changed the title Modify TRX40 Aorus Master Map Rewrite mixer map for TRX40 Aorus Master Jul 29, 2022
Copy link

@bflanagin bflanagin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The good:
Ports now appear to be mapped correctly
Sound now comes out of the port
The Bad:
In my tests every 3rd hot plug caused the sound to become distorted and at worst just loud static.
Could be the way I'm testing the PR.

The Test:
Using a preinstalled version of Pop 22.04 on an external drive. I installed the PR after verifying the prerequisites were installed.
Rebooted for good measure
Plugged in headphones to rear out (worked)
Plugged in headphones to line out (worked)
Plugged in headphone to rear out (loud crackles)
Continued till both ports just gave clicking noises.

@bflanagin
Copy link

Realized that this is just the definition files and not anything to do with the sound quality. The PR does what it is meant to do.

@13r0ck 13r0ck merged commit c9172fb into master Jul 29, 2022
@leviport
Copy link
Member

Should we be concerned that the build failed for Focal?

@13r0ck 13r0ck deleted the mega-r1.1 branch July 29, 2022 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants