Skip to content
This repository has been archived by the owner on Jul 28, 2023. It is now read-only.

Move some tests from sp-mvm to runtime. #190

Merged
merged 4 commits into from
Apr 12, 2022
Merged

Move some tests from sp-mvm to runtime. #190

merged 4 commits into from
Apr 12, 2022

Conversation

singulared
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Mar 28, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2149566094

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 41.25%
Totals Coverage Status
Change from base Build 2092359133: 0.0%
Covered Lines: 113
Relevant Lines: 214
💛 - Coveralls

@singulared singulared marked this pull request as draft March 29, 2022 08:28
@borispovod
Copy link
Member

Hi there,

There is already tests for runtime, what's reason to create also runtime/tests/common?

@singulared singulared marked this pull request as ready for review April 11, 2022 14:31
borispovod
borispovod approved these changes Apr 11, 2022
View reviewed changes
Copy link
Member

@borispovod borispovod left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It contains only part of ensure_root checks, yet it's part of another task already, so approve 👍

@borispovod borispovod requested a review from boozook April 11, 2022 22:45
boozook
boozook approved these changes Apr 12, 2022
View reviewed changes
Copy link
Contributor

@boozook boozook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@boozook boozook merged commit 7c716a2 into master Apr 12, 2022
@boozook boozook deleted the extend-runtime-tests branch April 12, 2022 15:06
@boozook boozook mentioned this pull request Apr 28, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@boozook boozook boozook approved these changes

@borispovod borispovod borispovod approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@singulared @coveralls @borispovod @boozook