This repository has been archived by the owner on Jul 28, 2023. It is now read-only.
Refactor sp-mvm/tests/assets.rs #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bunch of const variables and obscure enum -> array index conversions were removed and replaced with Asset and Package structs. All modules and transactions are available in a separate modules as static variables. They are not Copy, so passing by reference is required. Binary data is loaded in runtime using once_cell crate. It allows to avoid recompilation on changes in assets.
Pull Request Test Coverage Report for Build 1288366527
💛 - Coveralls |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch of const variables and obscure enum -> array index conversions
were removed and replaced with Asset and Package structs. All modules
and transactions are available in a separate modules as static
variables. They are not Copy, so passing by reference is required.
Binary data is loaded in runtime using once_cell crate. It allows to
avoid recompilation on changes in assets.