This repository has been archived by the owner on Jul 28, 2023. It is now read-only.
Dev mode #104
Merged
Dev mode #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1319623281
💛 - Coveralls |
Fixes #100 New flag `--dev-service` added to CLI. Implementation is basically copied from Moonbeam project, with some simplifications. Node is using sc_consensus_manual_seal crate to fake consensus. Code in node/service.rs simplified and slightly refactored. Removed unused parachain_build_import_queue function.
instead of declaring modules in both crates.
Remove redundant generic type parameters from functions, abstract build_consensus function to reduce the indentation.
borispovod
approved these changes
Oct 8, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement dev-mode for node
Fixes #100
New flag
--dev-serviceadded to CLI. Implementation is basicallycopied from Moonbeam project, with some simplifications. Node is using
sc_consensus_manual_seal crate to fake consensus.
Code in node/service.rs simplified and slightly refactored. Removed
unused parachain_build_import_queue function.