Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete refactoring, use hyper/h2 for connecting async. #5

Closed
wants to merge 8 commits into from

Conversation

pimeys
Copy link
Contributor

@pimeys pimeys commented Feb 8, 2018

Just a test right now, DO NOT MERGE!

Are you still maintaining the library? I've been working on the past year finding out the best way of sending apple pushes, and now when hyper starts to support http2, we can solve lots of problems.

This is:

  • Async and very fast
  • Uses serde for serialization
  • Support for cert and token auth
  • rust-openssl 0.9
  • No more solicit, hyper all the way
  • The whole api needed to change

Now, I only tested the certificate part and this is the first ever working connection with hyper + h2 + alpn. Token part needs to be tested tomorrow. Also I should write more rustdoc. The alpn connector should stay out of this library, it's here because I needed one and there are no libraries providing it for hyper yet.

The question is should you merge this or should I create a new library such as tokio-apns2? I'm using rustls for alpn, I don't know does it work in OSX. I'm developing this with a Linux system.

What do you think?

@pimeys
Copy link
Contributor Author

pimeys commented Feb 10, 2018

hyperium/hyper#304

@pimeys pimeys changed the title TODO: Complete refactoring, use hyper/h2 for connecting async. Complete refactoring, use hyper/h2 for connecting async. Feb 20, 2018
@pimeys
Copy link
Contributor Author

pimeys commented Feb 20, 2018

Works, but only tested with some hundreds of notifications, going to try this with some millions of notifications more before declaring stable. Should be MUCH faster than with solicit. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants