Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Throw proper error for empty char params in scan_csv #19100

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

coastalwhite
Copy link
Collaborator

Fixes #19099.

@coastalwhite coastalwhite changed the title fix: Throw proper error for char params in scan_csv fix: Throw proper error for empty char params in scan_csv Oct 4, 2024
@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Oct 4, 2024
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.78%. Comparing base (f55658b) to head (7d598e3).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19100      +/-   ##
==========================================
+ Coverage   79.77%   79.78%   +0.01%     
==========================================
  Files        1531     1531              
  Lines      208529   208547      +18     
  Branches     2913     2913              
==========================================
+ Hits       166347   166392      +45     
+ Misses      41631    41604      -27     
  Partials      551      551              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit d255d73 into pola-rs:main Oct 4, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scan_csv PanicException if quote_char is empty string
2 participants