Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Only rewrite numeric ineq joins #19083

Merged
merged 1 commit into from
Oct 3, 2024
Merged

fix: Only rewrite numeric ineq joins #19083

merged 1 commit into from
Oct 3, 2024

Conversation

ritchie46
Copy link
Member

fixes #19080

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Oct 3, 2024
@ritchie46 ritchie46 merged commit 310b482 into main Oct 3, 2024
24 checks passed
@ritchie46 ritchie46 deleted the join branch October 3, 2024 09:16
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 2 lines in your changes missing coverage. Please review.

Project coverage is 79.77%. Comparing base (35946cf) to head (e086a99).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-plan/src/plans/conversion/join.rs 90.90% 1 Missing ⚠️
.../polars-plan/src/plans/optimizer/collapse_joins.rs 93.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #19083   +/-   ##
=======================================
  Coverage   79.76%   79.77%           
=======================================
  Files        1531     1531           
  Lines      208521   208545   +24     
  Branches     2913     2913           
=======================================
+ Hits       166332   166365   +33     
+ Misses      41638    41629    -9     
  Partials      551      551           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic on join_where with string ordering since 1.8.0
1 participant