docs(python): warn that "by" argument must be sorted for results to be correct in rolling_* functions #11013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e correct in rolling_* functions
MarcoGorelli
requested review from
ritchie46,
stinodego and
alexander-beedie
as code owners
2 tasks
github-actions
bot
added
documentation
stinodego
approved these changes
Sep 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reference: #10991
I'm short on time in the coming weeks so won't have time to work on the suggested solution in #10991 (comment) before the next release
Does anyone have time to implement it for 0.19.3? I'm travelling and so don't have time for anything non-trivial at the moment I'm afraid
If not, then I'd appreciate it if either this or #11002 could make it in for 0.19.3
Polars downloads are exploding and I'm worried that someone might get wrong results and lose faith in the library