Remove unnecessary ok() from openapi-derive (#590)

Clippy complains about this in crates using the derive(Union)
poem-web · Jun 21, 2023 · bb33f55 · bb33f55
1 parent 8b55dd1
commit bb33f55
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/poem-openapi-derive/src/union.rs b/poem-openapi-derive/src/union.rs
@@ -105,18 +105,16 @@ pub(crate) fn generate(args: DeriveInput) -> GeneratorResult<TokenStream> {
                 } else if !args.one_of {
                     // any of
                     from_json.push(quote! {
-                        if let ::std::option::Option::Some(obj) = <#object_ty as #crate_name::types::ParseFromJSON>::parse_from_json(::std::option::Option::Some(::std::clone::Clone::clone(&value)))
-                            .map(Self::#item_ident)
-                            .ok() {
+                        if let ::std::result::Result::Ok(obj) = <#object_ty as #crate_name::types::ParseFromJSON>::parse_from_json(::std::option::Option::Some(::std::clone::Clone::clone(&value)))
+                            .map(Self::#item_ident) {
                             return ::std::result::Result::Ok(obj);
                         }
                     });
                 } else {
                     // one of
                     from_json.push(quote! {
-                        if let ::std::option::Option::Some(obj) = <#object_ty as #crate_name::types::ParseFromJSON>::parse_from_json(::std::option::Option::Some(::std::clone::Clone::clone(&value)))
-                            .map(Self::#item_ident)
-                            .ok() {
+                        if let ::std::result::Result::Ok(obj) = <#object_ty as #crate_name::types::ParseFromJSON>::parse_from_json(::std::option::Option::Some(::std::clone::Clone::clone(&value)))
+                            .map(Self::#item_ident) {
                             if res_obj.is_some() {
                                 return ::std::result::Result::Err(#crate_name::types::ParseError::expected_type(value));
                             }