Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actions_bulk bugs #1028

Closed
basepack opened this issue Feb 1, 2013 · 2 comments
Closed

actions_bulk bugs #1028

basepack opened this issue Feb 1, 2013 · 2 comments
Assignees
Milestone

Comments

@basepack
Copy link

basepack commented Feb 1, 2013

To reproduce:

  • Create a pod
  • Use pods_ui to create a UI for backend
  • Use this code to create a custom bulk action:
    'actions_bulk' => array(
    'assign_region' => array('label' => 'Assign to region', 'callback' => 'actions_bulk_assign_region'),
    'delete' => array('label' => 'Delete customers')
    ),

Bug 1: In the WP Admin try to use the 'Assign to region' button twice for some items. The second time there will be a bad GET request: Look here:
http://www.domain.com/voorbeeld/wp-admin/admin.php?page=customers&page=customers&action_bulk=assign_region&action_bulk_ids=Array&search=&action_bulk=assign_region&action_bulk_ids%5B%5D=1
Look at action_bulk_ids there twice. One time with Array as a paramater.

Bug 2: When using a callback, as I do: 'actions_bulk_assign_region'. Then the callback gets never fired.

@sc0ttkclark
Copy link
Member

Fixed bug #1, which likely fixed bug #2 because I can't reproduce it (all callbacks work fine for me).

@basepack
Copy link
Author

Thank you Scott.

Also, when you do not select any items in the list, and select a Bulk action an run it, you will get a PHP warning back that the array is not an array.

@sc0ttkclark sc0ttkclark reopened this Feb 13, 2013
sc0ttkclark added a commit that referenced this issue Feb 14, 2013
sc0ttkclark added a commit that referenced this issue Feb 14, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants