Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert useShallow refactor in #2701 #2703

Merged
merged 2 commits into from
Sep 15, 2024
Merged

revert useShallow refactor in #2701 #2703

merged 2 commits into from
Sep 15, 2024

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Aug 27, 2024

I was rushing too much.

#2701 was to avoid react compiler warning, but it seems like the warning was caused because of destructuring ReactExports. The eslint rules aren't capable of it. Instead, let's use traditional React.useRef. This reverts #2701.

Copy link

vercel bot commented Aug 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 15, 2024 2:14am

Copy link

codesandbox-ci bot commented Aug 27, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

github-actions bot commented Aug 27, 2024

Size Change: -203 B (-1.67%)

Total Size: 12 kB

Filename Size Change
./dist/esm/react.mjs 320 B -13 B (-3.9%)
./dist/esm/react/shallow.mjs 193 B -81 B (-29.56%) 🎉
./dist/esm/traditional.mjs 411 B -5 B (-1.2%)
./dist/react.js 336 B -17 B (-4.82%)
./dist/react/shallow.js 208 B -80 B (-27.78%) 🎉
./dist/traditional.js 423 B -7 B (-1.63%)
ℹ️ View Unchanged
Filename Size
./dist/esm/index.mjs 64 B
./dist/esm/middleware.mjs 3.56 kB
./dist/esm/middleware/immer.mjs 210 B
./dist/esm/shallow.mjs 82 B
./dist/esm/vanilla.mjs 403 B
./dist/esm/vanilla/shallow.mjs 550 B
./dist/index.js 244 B
./dist/middleware.js 3.56 kB
./dist/middleware/immer.js 229 B
./dist/shallow.js 189 B
./dist/vanilla.js 416 B
./dist/vanilla/shallow.js 562 B

compressed-size-action

@dai-shi dai-shi merged commit c08adc2 into main Sep 15, 2024
26 checks passed
@dai-shi dai-shi deleted the revert-2701 branch September 15, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant