Remove extension warning #2405
Remove extension warning #2405
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
There was a problem hiding this comment.
I think this is pretty reasonable now, because it's introduced in v2 or before, when nobody was using it with nextjs.
Many have complained since then, and we added enabled for more control.
But, I suspect this message doesn't help many people. We should probably improve the docs to make sure people install the browser extension.
Removing the message entirely should improve the overall DX. (I know some environments has window defined even in Node.js.)
|
One thing we can consider is whether we should add this only in v5, assuming it's a kind of breaking changes. |
|
Would anyone like to open a PR to |
|
I agree that this change is likely best done as a breaking change in v5. I will make a PR. |
|
superseded by #2466 |
Related Issues or Discussions
#2404
Summary
This PR removes the Redux extension warning entirely.