Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: disable pmem2_map_from_existing TEST[0-2] until #5594 is fixed. #5663

Merged
merged 1 commit into from
May 19, 2023

Conversation

grom72
Copy link
Contributor

@grom72 grom72 commented May 19, 2023

Disable tests pmem2_map_from_existing - TEST[0-2] for memcheck until #5594 is fixed.


This change is Reviewable

@grom72 grom72 requested review from janekmi and osalyk May 19, 2023 08:01
Copy link
Contributor

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72 and @janekmi)


-- commits line 2 at r1:
test name, please

Copy link
Contributor

@osalyk osalyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @janekmi)

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #5663 (dab04b8) into stable-1.13 (9c975da) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           stable-1.13    #5663      +/-   ##
===============================================
- Coverage        74.27%   74.26%   -0.01%     
===============================================
  Files              145      145              
  Lines            22131    22131              
  Branches          3702     3704       +2     
===============================================
- Hits             16438    16436       -2     
- Misses            5693     5695       +2     

@grom72 grom72 added this to the 1.13 on GHA milestone May 19, 2023
Copy link
Contributor

@janekmi janekmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @grom72)

@grom72 grom72 changed the title test: disable TEST[0-2] until #5594 is fixed. test: disable pmem2_map_from_existing TEST[0-2] until #5594 is fixed. May 19, 2023
Disable tests pmem2_map_from_existing TEST[0-2] for memcheck
until pmem#5594 is fixed.

Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@intel.com>
Copy link
Contributor Author

@grom72 grom72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @grom72)


-- commits line 2 at r1:

Previously, osalyk (Oksana Sałyk) wrote…

test name, please

Done

@janekmi janekmi merged commit 7f08703 into pmem:stable-1.13 May 19, 2023
@grom72 grom72 deleted the test-fix-5594 branch May 25, 2023 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants