[apex] Invalid Apex in Cognitive Complexity tests

[rsoesemann]

The Cognitive Complexity rule added by @gwilymatgearset in PMD 6.22 (#2297) has text sample code that is no valid Apex.

Please check and fix ALL instances but here are a few issues:

• Uses double quotes instead of single quotes for Strings
• Uses Lowercase Type names string instead of String
• method setPhoneNumberIfNotExisting is missing a return;

Here's the example code, that needs to be fixed:

pmd/pmd-apex/src/main/resources/category/apex/design.xml

Lines 112 to 143 in 31bf08a

	public class Foo {
	// Has a cognitive complexity of 0
	public void createAccount() {
	Account account = new Account(Name = 'PMD');
	insert account;
	}
	// Has a cognitive complexity of 1
	public Boolean setPhoneNumberIfNotExisting(Account a, String phone) {
	if (a.Phone == null) { // +1
	a.Phone = phone;
	update a;
	}
	}
	// Has a cognitive complexity of 5
	public void updateContacts(List<Contact> contacts) {
	List<Contact> contactsToUpdate = new List<Contact>();
	for (Contact contact : contacts) { // +1
	if (contact.Department == 'Finance') { // +2
	contact.Title = 'Finance Specialist';
	contactsToUpdate.add(contact);
	} else if (contact.Department == 'Sales') { // +2
	contact.Title = 'Sales Specialist';
	contactsToUpdate.add(contact);
	}
	}
	update contactsToUpdate;
	}
	}

[rsoesemann]

@adangel @gwilymatgearset will work on this. The original contributor. I couldnt assign it to him. Can you?

[adangel]

I've invited him now as a outside collaborator. @gwilymatgearset can you accept the invite? Then I can assign the issue to you... thanks

[gwilymatgearset]

@rsoesemann I'm slightly confused by 2 of your comments :)

Uses double quotes instead of single quotes for Strings

That makes it invalid apex doesn't it?

Uses Lowercase Type names string instead of String

I went for upper case rather than lower case here because that's what salesforce do in all of their documentation (and what they do in trailhead)
https://developer.salesforce.com/docs/atlas.en-us.apexcode.meta/apexcode/langCon_apex_variables.htm

[rsoesemann]

@gwilymatgearset Sorry for the confusion. Your examples just dont compile because of the missing returns but other Apex examples in the same XML are faulty. I mixed this up. If you have time to fix them in one go this would be awesome.

[gwilymatgearset]

Can do :).