Remove unnecessary source-type tags in rule tests

source-type is actually only needed if * the language supports more than one version * the parser behaves differently with different versions (this has to do with compatibility, e.g. assert/enum keywords in java) * the test needs a newer version than the default version (e.g. to test new language features) * the test needs an older version than the default version (e.g. the rule has a maximumLanguageVersion specified) * the rule behaves differently for different versions (e.g. BigIntegerInstantiation)
pmd · May 23, 2020 · a3a292d · a3a292d
1 parent 5618257
commit a3a292d
Show file tree

Hide file tree

Showing 80 changed files with 0 additions and 330 deletions.
diff --git a/...est/resources/net/sourceforge/pmd/lang/java/rule/bestpractices/xml/PreserveStackTrace.xml b/...est/resources/net/sourceforge/pmd/lang/java/rule/bestpractices/xml/PreserveStackTrace.xml
@@ -370,7 +370,6 @@ class MultiCatch {
     }
 }
         ]]></code>
-        <source-type>java 1.7</source-type>
     </test-code>
 
     <test-code>
@@ -388,7 +387,6 @@ class MultiCatch {
     }
 }
         ]]></code>
-        <source-type>java 1.7</source-type>
     </test-code>
 
     <test-code>

diff --git a/...src/test/resources/net/sourceforge/pmd/lang/java/rule/bestpractices/xml/UnusedImports.xml b/...src/test/resources/net/sourceforge/pmd/lang/java/rule/bestpractices/xml/UnusedImports.xml
@@ -70,7 +70,6 @@ public class Foo {
     }
 }
         ]]></code>
-        <source-type>java 1.5</source-type>
     </test-code>
 
     <test-code>
@@ -82,7 +81,6 @@ public class Foo {
     private List<TestInterfaceTwo> x = new ArrayList<TestInterfaceTwo>();
 }
         ]]></code>
-        <source-type>java 1.5</source-type>
     </test-code>
 
     <test-code>
@@ -96,7 +94,6 @@ public class Foo {
     private List<Collection> x = new ArrayList<Collection>();
 }
         ]]></code>
-        <source-type>java 1.5</source-type>
     </test-code>
 
     <test-code>
@@ -109,7 +106,6 @@ import foo.annotation.RetentionPolicy;
 public @interface Foo {
 }
         ]]></code>
-        <source-type>java 1.5</source-type>
     </test-code>
 
     <test-code>
@@ -122,7 +118,6 @@ import foo.FooAnnotation2;
 @FooAnnotation2
 public class Foo {}
         ]]></code>
-        <source-type>java 1.5</source-type>
     </test-code>
 
     <test-code>
@@ -158,7 +153,6 @@ public class Foo {
     }
 }
         ]]></code>
-        <source-type>java 1.5</source-type>
     </test-code>
 
     <test-code>
@@ -171,7 +165,6 @@ public class Foo {
     }
 }
         ]]></code>
-        <source-type>java 1.5</source-type>
     </test-code>
 
     <test-code>

diff --git a/...st/resources/net/sourceforge/pmd/lang/java/rule/bestpractices/xml/UnusedLocalVariable.xml b/...st/resources/net/sourceforge/pmd/lang/java/rule/bestpractices/xml/UnusedLocalVariable.xml
@@ -320,7 +320,6 @@ public class Foo {
     }
 }
         ]]></code>
-        <source-type>java 1.8</source-type>
     </test-code>
 
     <test-code>

diff --git a/...st/resources/net/sourceforge/pmd/lang/java/rule/bestpractices/xml/UnusedPrivateMethod.xml b/...st/resources/net/sourceforge/pmd/lang/java/rule/bestpractices/xml/UnusedPrivateMethod.xml
@@ -382,7 +382,6 @@ public class Foo {
     }
 }
         ]]></code>
-        <source-type>java 1.8</source-type>
     </test-code>
 
     <test-code>

diff --git a/...est/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/CallSuperInConstructor.xml b/...est/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/CallSuperInConstructor.xml
@@ -54,6 +54,5 @@ public class Bar extends Buz {
     }
 }
         ]]></code>
-        <source-type>java 1.5</source-type>
     </test-code>
 </test-data>
diff --git a/...rc/test/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/DontImportJavaLang.xml b/...rc/test/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/DontImportJavaLang.xml
@@ -43,7 +43,6 @@ public class Foo {}
 import static java.lang.*;
 public class Foo {}
         ]]></code>
-        <source-type>java 1.5</source-type>
     </test-code>
 
     <test-code>

diff --git a/...t/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/ForLoopShouldBeWhileLoop.xml b/...t/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/ForLoopShouldBeWhileLoop.xml
@@ -55,6 +55,5 @@ public class Foo {
     }
 }
         ]]></code>
-        <source-type>java 1.5</source-type>
     </test-code>
 </test-data>
diff --git a/...rc/test/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/UseDiamondOperator.xml b/...rc/test/resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/UseDiamondOperator.xml
@@ -161,7 +161,6 @@ public class Foo {
     }
 }
         ]]></code>
-        <source-type>java 1.7</source-type>
     </test-code>
 
     <test-code regressionTest="false">
@@ -178,6 +177,5 @@ public class Foo {
     }
 }
         ]]></code>
-        <source-type>java 1.8</source-type>
     </test-code>
 </test-data>
diff --git a/.../resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/VariableNamingConventions.xml b/.../resources/net/sourceforge/pmd/lang/java/rule/codestyle/xml/VariableNamingConventions.xml
@@ -290,7 +290,6 @@ public class Test {
     private static final RemoteRepository REMOTE = new RemoteRepository<>();
 }
         ]]></code>
-        <source-type>java 1.7</source-type>
     </test-code>
 
     <test-code>

diff --git a/...sources/net/sourceforge/pmd/lang/java/rule/design/xml/SignatureDeclareThrowsException.xml b/...sources/net/sourceforge/pmd/lang/java/rule/design/xml/SignatureDeclareThrowsException.xml
@@ -154,7 +154,6 @@ public class Foo {
     public <T> Bar<T> foo() { /* blah */}
 }
         ]]></code>
-        <source-type>java 1.5</source-type>
     </test-code>
 
     <test-code>

diff --git a/...s/net/sourceforge/pmd/lang/java/rule/errorprone/xml/ConstructorCallsOverridableMethod.xml b/...s/net/sourceforge/pmd/lang/java/rule/errorprone/xml/ConstructorCallsOverridableMethod.xml
@@ -152,7 +152,6 @@ public enum Buz {
     private Buz(String s) {}
 }
         ]]></code>
-        <source-type>java 1.5</source-type>
     </test-code>
 
     <test-code>

diff --git a/...sources/net/sourceforge/pmd/lang/java/rule/errorprone/xml/UselessOperationOnImmutable.xml b/...sources/net/sourceforge/pmd/lang/java/rule/errorprone/xml/UselessOperationOnImmutable.xml
@@ -86,7 +86,6 @@ public class Foo {
     }
 }
         ]]></code>
-        <source-type>java 1.5</source-type>
     </test-code>
 
     <test-code>

diff --git a/.../resources/net/sourceforge/pmd/lang/java/rule/multithreading/xml/DoubleCheckedLocking.xml b/.../resources/net/sourceforge/pmd/lang/java/rule/multithreading/xml/DoubleCheckedLocking.xml
@@ -52,7 +52,6 @@ public class Foo {
     public <T> Bar<T> foo() { /* blah */}
 }
         ]]></code>
-        <source-type>java 1.5</source-type>
     </test-code>
 
     <test-code>

diff --git a/...s/net/sourceforge/pmd/lang/java/rule/performance/xml/UnnecessaryWrapperObjectCreation.xml b/...s/net/sourceforge/pmd/lang/java/rule/performance/xml/UnnecessaryWrapperObjectCreation.xml
@@ -38,7 +38,6 @@ public class Bar {
     }
 }
         ]]></code>
-        <source-type>java 1.5</source-type>
     </test-code>
 
     <test-code>

diff --git a/.../src/test/resources/net/sourceforge/pmd/lang/java/rule/performance/xml/UseIndexOfChar.xml b/.../src/test/resources/net/sourceforge/pmd/lang/java/rule/performance/xml/UseIndexOfChar.xml
@@ -144,7 +144,6 @@ public class FooTest {
     }
 }
         ]]></code>
-        <source-type>java 1.8</source-type>
     </test-code>
 
     <test-code>
@@ -160,7 +159,6 @@ public class Foo {
     }
 }
         ]]></code>
-        <source-type>java 1.8</source-type>
     </test-code>
 
     <test-code>
@@ -178,6 +176,5 @@ public class LocalVariableTypeInferenceTryWithResources {
     }
 }
         ]]></code>
-        <source-type>java 10</source-type>
     </test-code>
 </test-data>
diff --git a/...sources/net/sourceforge/pmd/lang/ecmascript/rule/bestpractices/xml/AvoidWithStatement.xml b/...sources/net/sourceforge/pmd/lang/ecmascript/rule/bestpractices/xml/AvoidWithStatement.xml
@@ -12,6 +12,5 @@ with (object) {
     property = 3; // Might be on object, might be on window: who knows.
 }
         ]]></code>
-        <source-type>ecmascript 3</source-type>
     </test-code>
 </test-data>
diff --git a/...resources/net/sourceforge/pmd/lang/ecmascript/rule/bestpractices/xml/ConsistentReturn.xml b/...resources/net/sourceforge/pmd/lang/ecmascript/rule/bestpractices/xml/ConsistentReturn.xml
@@ -11,7 +11,6 @@
 function foo() {
 }
         ]]></code>
-        <source-type>ecmascript 3</source-type>
     </test-code>
 
     <test-code>
@@ -22,7 +21,6 @@ function foo() {
     return true;
 }
         ]]></code>
-        <source-type>ecmascript 3</source-type>
     </test-code>
 
     <test-code>
@@ -33,7 +31,6 @@ function foo() {
     return;
 }
         ]]></code>
-        <source-type>ecmascript 3</source-type>
     </test-code>
 
     <test-code>
@@ -47,7 +44,6 @@ function foo() {
     return;
 }
         ]]></code>
-        <source-type>ecmascript 3</source-type>
     </test-code>
 
     <test-code>
@@ -61,7 +57,6 @@ function foo() {
     return;
 }
         ]]></code>
-        <source-type>ecmascript 3</source-type>
     </test-code>
 
     <test-code>
@@ -81,6 +76,5 @@ function foo() {
     return;
 }
         ]]></code>
-        <source-type>ecmascript 3</source-type>
     </test-code>
 </test-data>
diff --git a/...t/resources/net/sourceforge/pmd/lang/ecmascript/rule/bestpractices/xml/GlobalVariable.xml b/...t/resources/net/sourceforge/pmd/lang/ecmascript/rule/bestpractices/xml/GlobalVariable.xml
@@ -16,7 +16,6 @@ function(arg) {
     };
 }
         ]]></code>
-        <source-type>ecmascript 3</source-type>
     </test-code>
 
     <test-code>
@@ -36,6 +35,5 @@ function(arg) {
     };
 }
         ]]></code>
-        <source-type>ecmascript 3</source-type>
     </test-code>
 </test-data>
diff --git a/...sources/net/sourceforge/pmd/lang/ecmascript/rule/bestpractices/xml/ScopeForInVariable.xml b/...sources/net/sourceforge/pmd/lang/ecmascript/rule/bestpractices/xml/ScopeForInVariable.xml
@@ -12,7 +12,6 @@ for (var p in obj) {
     obj[p] = obj[p];
 }
         ]]></code>
-        <source-type>ecmascript 3</source-type>
     </test-code>
 
     <test-code>
@@ -25,7 +24,6 @@ function foo() {
     }
 }
         ]]></code>
-        <source-type>ecmascript 3</source-type>
     </test-code>
 
     <test-code>
@@ -46,7 +44,6 @@ function foo() {
     // 'p' still has value of 'clean'.
 }
         ]]></code>
-        <source-type>ecmascript 3</source-type>
     </test-code>
 
     <test-code>
@@ -57,7 +54,6 @@ for (p in obj) {
     obj[p] = obj[p];
 }
         ]]></code>
-        <source-type>ecmascript 3</source-type>
     </test-code>
 
     <test-code>
@@ -70,7 +66,6 @@ function() {
     }
 };
         ]]></code>
-        <source-type>ecmascript 3</source-type>
     </test-code>
 
     <test-code>
@@ -91,6 +86,5 @@ function bar() {
     // 'p' is trashed and has value of 'dirty'!
 }
         ]]></code>
-        <source-type>ecmascript 3</source-type>
     </test-code>
 </test-data>
diff --git a/...ources/net/sourceforge/pmd/lang/ecmascript/rule/bestpractices/xml/UseBaseWithParseInt.xml b/...ources/net/sourceforge/pmd/lang/ecmascript/rule/bestpractices/xml/UseBaseWithParseInt.xml
@@ -10,7 +10,6 @@
         <code><![CDATA[
 parseInt("10");
         ]]></code>
-        <source-type>ecmascript 3</source-type>
     </test-code>
 
     <test-code>
@@ -19,6 +18,5 @@ parseInt("10");
         <code><![CDATA[
 parseInt("10", 16);
         ]]></code>
-        <source-type>ecmascript 3</source-type>
     </test-code>
 </test-data>