up

.github/workflows/validation-rust.yaml

@@ -14,8 +14,8 @@ on:
 name: Rust Validation
 
 env:
-  # RUSTDOCFLAGS: -D warnings
-  # RUSTFLAGS: -D warnings -C debuginfo=1
+  RUSTDOCFLAGS: -D warnings
+  RUSTFLAGS: -D warnings -C debuginfo=1
   RUST_BACKTRACE: 1
   CARGO_REGISTRIES_CRATES_IO_PROTOCOL: sparse
 

udf-examples/src/avg2.rs

@@ -1,10 +1,10 @@
-//! Aggregate cost window function
+//! Example average function
 //!
-//! Takes a quantity and a real to return the average value within the window.
+//! This is just a reimplemenation of builtin `AVG`
 //!
 //! ```sql
 //! CREATE FUNCTION avg2 RETURNS integer SONAME 'libudf_examples.so';
-//! SELECT avg2(int_column, real_column);
+//! SELECT avg2(value);
 //! ```
 // Ignore loss of precision when we cast i64 to f64
 #![allow(clippy::cast_precision_loss)]

udf-examples/tests/avgcost.rs

@@ -31,7 +31,7 @@ const SETUP: &[&str] = &[
 fn test_empty() {
     let conn = &mut get_db_connection(&SETUP);
 
-    let res: Vec<f64> = conn
+    let res: Vec<f32> = conn
         .query("SELECT avg_cost(qty, cost) FROM test_avgcost GROUP BY class")
         .unwrap();
 

udf-examples/tests/backend/mod.rs

@@ -69,3 +69,8 @@ pub fn get_db_connection(init: &[&str]) -> PooledConn {
 
     conn
 }
+
+pub fn approx_eq(a: f32, b: f32) -> bool {
+    const TOLERANCE: f32 = 0.001;
+    (a - b).abs() < TOLERANCE
+}

udf-examples/tests/sequence.rs

@@ -6,13 +6,13 @@ use backend::get_db_connection;
 use mysql::prelude::*;
 
 const SETUP: &[&str] = &[
-    "create or replace function udf_sequence
-        returns integer
-        soname 'libudf_examples.so'",
-    "create or replace table test_seq (
+    "CREATE OR REPLACE FUNCTION udf_sequence
+        RETURNS integer
+        SONAME 'libudf_examples.so'",
+    "CREATE OR REPLACE TABLE test_seq (
         id int
     )",
-    "insert into test_seq (id) values (1), (2), (3), (4), (5), (6)",
+    "INSERT INTO test_seq (id) VALUES (1), (2), (3), (4), (5), (6)",
 ];
 
 #[test]