Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boxpoints no range #915

Merged
merged 3 commits into from
Sep 8, 2016
Merged

Boxpoints no range #915

merged 3 commits into from
Sep 8, 2016

Conversation

alexcjohnson
Copy link
Collaborator

Fixes #725 - problems with the box plot jitter algorithm when there's no interquartile range (or even no range at all) - by falling back on a fraction of the total range or, barring that, just disabling the adaptive jitter.

screen shot 2016-09-07 at 7 54 20 pm

screen shot 2016-09-07 at 8 09 11 pm

@etpinard OK?

@alexcjohnson
Copy link
Collaborator Author

Fixes #574 as well.

Using the data from https://jsfiddle.net/cf4j5vxz/ -
screen shot 2016-09-07 at 8 30 37 pm

@etpinard etpinard added bug something broken status: reviewable labels Sep 8, 2016
@etpinard
Copy link
Contributor

etpinard commented Sep 8, 2016

Looks good, Thanks!

Are you all set to add a couple image tests? If you're too busy, I can take it from here and make this PR part of v1.17.0 to be released tomorrow.

@alexcjohnson
Copy link
Collaborator Author

@etpinard + test image expanding on #725

@etpinard
Copy link
Contributor

etpinard commented Sep 8, 2016

beautifully done 💃

@etpinard etpinard added this to the v1.17.0 milestone Sep 8, 2016
@alexcjohnson alexcjohnson merged commit 26ea20c into master Sep 8, 2016
@alexcjohnson alexcjohnson deleted the boxpoints-no-range branch September 8, 2016 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something broken
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants