Notifier logging #4464
Merged
Notifier logging #4464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- set valType to 'integer' - set min and max
- add option to notifier such that it stays on-graph w/o fading out - within lib/loggers, call notifier with log/warn/error messages
... so that the error message can show up on the graph when
the onGraphLogging config option is turned on.
|
|
|
|
|
|
I'm a fan of this. Is everyone in @plotly/plotly_js ok with this? |
I'm fine with it. |
|
@etpinard this PR is ready to 💃 |
|
New demos with
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4098 by implementing what was proposed in #4098 (comment)
Demos:
Updated in #4464 (comment)
I kept the config option name
onGraphLoggingto start this PR. The namenotifyOnWarningshas also been proposed, but since the same config option applies to both "logs" and "warnings", maybe we could do better. Please let me know if you can think of a better option name or if you thinknotifyOnWarningsis the way to go.@archmoj @nicolaskruchten