Fix image exports for new #4386 mocks with SVG gradients #4441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... during image exports, instead of having hard-coded list
of query-selectors in toSVG routine.
etpinard
commented
Dec 24, 2019
| var svgDOM = parser.parseFromString(svg, 'image/svg+xml'); | ||
|
|
||
| var fillItems = svgDOM.getElementsByClassName('legend3dandfriends'); | ||
| expect(fillItems.length).toBe(4, '# of legend items'); |
There was a problem hiding this comment.
Before this PR, fillItems.length was 0
etpinard
commented
Dec 24, 2019
| }; | ||
| var k = className2query(d3.select(sel.node().parentNode)) + | ||
| '>' + className2query(sel); | ||
| fullLayout._gradientUrlQueryParts[k] = 1; |
There was a problem hiding this comment.
We could go further by trying to construct a full xpath for each nodes with a gradient url, but I think this here is good enough for now.
|
@etpinard |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4438 - a follow-up from #4386.
Please note that exporting those new mocks worked fine in our (old)
imagetestcontainer, the problem was only noticed during a./tasks/noci_test.shrun.Commit b4ac79e is the bare-bone fix and test 🔒
Commit 55d76b2 introduces a more robust way of handling gradient URL strings during image exports. Let me know what you think!
cc @archmoj