Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent text mode for bar-like & pie-like traces and feature to control text orientation inside pie/sunburst slices #4420

Merged
merged 20 commits into from
Dec 23, 2019
Merged

Consistent text mode for bar-like & pie-like traces and feature to control text orientation inside pie/sunburst slices #4420

merged 20 commits into from
Dec 23, 2019

Commits on Dec 12, 2019

  1. add uniformtext attributes to layout

    @archmoj
    archmoj committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    0d3e289 View commit details
    Browse the repository at this point in the history

  2. simplify transform function and expand to reuse in pie and sunburst

    @archmoj
    archmoj committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    c095271 View commit details
    Browse the repository at this point in the history

  3. implement uniformtext for bar-like traces as well as funnelarea and t… 

    …reemap
    @archmoj
    archmoj committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    b234d7a View commit details
    Browse the repository at this point in the history

  4. implement uniformtext and insidetext-orientation for pie and sunburst

    @archmoj
    archmoj committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    f0ac957 View commit details
    Browse the repository at this point in the history

  5. add new mocks to test insidetextorientation and uniformtext

    @archmoj
    archmoj committed Dec 12, 2019
    Configuration menu
    Copy the full SHA
    4d5fb3d View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2019

  1. Consider first review 

    - make pie insidetextorientation coerce condition more readable
- no need for extra check before recompute bounding box
- revise uniformtext attribute descriptions
- remove boolean from getTextTransform arguments
- add js doc description
- create and use Lib.ensureUniformFontSize
- make the hide/show logic independent of _module.plot
- refactor textposition coerce logic
- add test for inside-text-orientation coerce logic with various textposition scenarios
- use radial tangential and horizontal in inside-text-orientation keys
    @archmoj
    archmoj committed Dec 13, 2019
    Configuration menu
    Copy the full SHA
    a27dc29 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2019

  1. make tangential go towards noon and 6 and make radial go towards 3 and 9

    @archmoj
    archmoj committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    1479943 View commit details
    Browse the repository at this point in the history

  2. rewrite uniform text style

    @archmoj
    archmoj committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    eab205a View commit details
    Browse the repository at this point in the history

  3. add new mocks cases by Nicolas

    @archmoj
    archmoj committed Dec 18, 2019
    Configuration menu
    Copy the full SHA
    5348c58 View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2019

  1. apply zero scale for hiding text elements 

    - bypass points without text
- add react tests for bar, waterfall, funnel, funnelarea, pie uniform-text options
- add react tests for pie inside-text-orientation options
    @archmoj
    archmoj committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    15ce24d View commit details
    Browse the repository at this point in the history

  2. add new mocks using both inside-text-orientation and uniformtext

    @archmoj
    archmoj committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    0840d82 View commit details
    Browse the repository at this point in the history

  3. move reposition logic outside pie transformInsideText function

    @archmoj
    archmoj committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    328ffd0 View commit details
    Browse the repository at this point in the history

  4. apply next text position when it is not at the center

    @archmoj
    archmoj committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    2a31685 View commit details
    Browse the repository at this point in the history

  5. Apply polar coordinates to move text inside the slice during sunburst… 

    … transitions

- rename pxtxt to textPosAngle and other cleanups
- keep textPosAngle inside transform
    @archmoj
    archmoj committed Dec 19, 2019
    Configuration menu
    Copy the full SHA
    d1b50b1 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2019

  1. sunburst handle no text when using various inside-text-orientation op… 

    …tions
    @archmoj
    archmoj committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    2cb5687 View commit details
    Browse the repository at this point in the history

  2. add react tests for treemap and pie uniform text as well as inside te… 

    …xt orientation
    @archmoj
    archmoj committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    beed042 View commit details
    Browse the repository at this point in the history

  3. add tests for updating text positions using different inside-text-pos… 

    …ition options
    @archmoj
    archmoj committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    51d7e1b View commit details
    Browse the repository at this point in the history

  4. wip

    @etpinard
    etpinard committed Dec 20, 2019
    Configuration menu
    Copy the full SHA
    603e0cc View commit details
    Browse the repository at this point in the history

Commits on Dec 23, 2019

  1. first attempt at fixing tests on etpinard's laptop 

    - use 14 (instead of 16) as "greater than fontsize dflt"
  `uniformtext.size` value
- add tolenrence to selected assertion in sunburst and treemap
  tween text assertions
    @etpinard
    etpinard committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    8784274 View commit details
    Browse the repository at this point in the history

  2. Fix funnelarea, pie, sunburst and treemap tests 

    - also fixed parsing rotation and scale values from transform
    @archmoj
    archmoj committed Dec 23, 2019
    Configuration menu
    Copy the full SHA
    2686c46 View commit details
    Browse the repository at this point in the history