Fix scattergl hover over nulls #4213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... so that we don't mutate pointData.cd and propagate 'fake'
`gd.calcdata[i][j]` to subsequent _module.hoverPoints calls.
- post #3578 all scattergl traces either set a `tree` or and `ids` array during the calc step.
archmoj
reviewed
Sep 23, 2019
|
@etpinard thanks very much for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4212 - a bug introduced in 1.45.0 as a side-effect of #3578
before: https://codepen.io/etpinard/pen/LYPqWYZ (hover over
x=3and check console)after: https://codepen.io/etpinard/pen/YzKBNbp?editors=1010
In
scatter/hover.js, we used to mutatepointData.cdin order to getscattergltraces to work with the parts ofFx.hoverthat expectgd.calcdata[i]to havelength=trace._length(which isn't the case forscattergl). Before #3578, we used to return early hereplotly.js/src/traces/scattergl/hover.js
Line 48 in 184c0b0
and the wrong
pointData.cdmutation did not occur.cc @archmoj