Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RU and UK locales and fix FR locale keys #4204

Merged
merged 2 commits into from
Sep 23, 2019

Conversation

KravtsovDV
Copy link

In commit c76b02f word 'titre' in locale keys (e.g. 'Click to enter X axis titre') was replaced with 'title' (e.g. 'Click to enter X axis title'), because otherwise those keys are not functional (example: https://codepen.io/KravtsovDV/pen/yLBRoeO).

In commit 18dcbe5 locales for russian and ukrainian were updated. @kserbez can check them.

I have some doubts concerning some translations. Among them:

  • I know no equivalent of KDE abbreviation, so it was translated using full (and long) phrases. This could be a problem for small plots.

  • I don't know where 'concentration:' in Sankey diagram is used. Better translation than the one I used might exist.

  • There are many variants of months abbreviations, so there could be better ones.

Also, there were three-letter abbreviations of days initially, but two-letter abbreviations are more common in russian and ukrainian.

@etpinard
Copy link
Contributor

Oh wow, thanks very much for fixing my dumb typos in c76b02f !

For

  • I don't know where 'concentration:' in Sankey diagram is used. Better translation than the one I used might exist.

Here's an example https://codepen.io/etpinard/pen/LYPXVbv?editors=1010 concentration hover info only appears when one sets a concentrationscale in a sankey trace.

For

  • I know no equivalent of KDE abbreviation, so it was translated using full (and long) phrases. This could be a problem for small plots.
  • There are many variants of months abbreviations, so there could be better ones.

Hmm, it's not obvious to me what's best. Reaching out to another native speaker might be the way to go.

Thanks very much for your help!!

@KravtsovDV
Copy link
Author

Judging by CodePen example I think current translation for 'concentration:' should be OK.

@kserbez
Copy link

kserbez commented Sep 19, 2019

I've checked the locales as native speaker. Everything seems fine.

shortMonths and shortDays look way better now!

As for KDE abbreviation, I don't know any abbreviation analog in Russian and Ukrainian and I haven't found them in the Internet. So, current version is semantically ok but might be a little bit long. If it's a problem than one of the solutions could be changing it simply to "KDE".

@etpinard etpinard added this to the v1.50.0 milestone Sep 19, 2019
@etpinard
Copy link
Contributor

Thanks very much @KravtsovDV and @kserbez for your help. Merging. This will be part of v1.50.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants