Axis category ordering - adds feature #189 #419

monfera · 2016-04-13T09:07:19Z

Original PR within downstream repo, with comments and historical commits: monfera#1

Implement axis attributes categorymode and categorylist to allow control of axis tick ordering independent of the trace order. See the attribute documentation, added Jasmine test cases and image tests for the API addition.

etpinard · 2016-04-13T14:08:46Z

src/plots/cartesian/layout_attributes.js

+    categorymode: {
+        valType: 'enumerated',
+        values: [
+            'trace', 'category ascending', 'category descending', 'array'


@cldougl @chriddyp does ⏫ look ok to you?

👍 for me

Maybe we should include truncated versions of those values as well e.g. 'cat asc', 'cat des' ?

I'd suggest avoiding muti-word strings. Maybe just ascending and descending?

for me just ascending`descendingdoesn't have a clear relation to _alpha_numeric ordering. I definitely understand the aversion to multi-word strings, but I would vote for more description thanascending\descending`

plus if 'value ascending' \ 'value descending' are going to be implemented eventually

but I gotta say, catergoryorder doesn't sound bad at all.

You can add them as labels to the axes (currently described as ticktext) or use them as data (currently described as x). Given that the axis.type is category, one might think that categories is how you would add data to that axis.

and maybe categoryarray instead of categorylist

@chriddyp we're already using the value 'array' for tickmode.

You can add them as labels to the axes

More like: categories are added automatically. Categories have no effect on ticktext.

Given that the axis.type is category, one might think that categories is how you would add data to that axis.

Great point 👍

That's why I'm thinking that categoryorder might be the winner here.

etpinard · 2016-04-13T15:05:02Z

@monfera we should also add one scatter3d test (similar to http://codepen.io/etpinard/pen/VaXmPx) showcasing one categorymode setting.

etpinard · 2016-04-14T20:17:45Z

@monfera

@chriddyp and I settled on categoryorder in place of categorymode and categoryarray in place of categorylist,

@monfera @cldougl @mdtusz any objections?

cldougl · 2016-04-14T20:18:46Z

👍 all good for me

monfera · 2016-04-15T03:20:11Z

@etpinard @chriddyp categoryorder and categoryarray are fine.

etpinard · 2016-04-18T20:29:38Z

@monfera Awesome work. 🍻

bmcole · 2016-06-13T21:17:54Z

Can someone provide an example (or point me to one) on how to use categoryorder = 'array' and categoryarray in order to manually specify the ordering of a categorical feature for plotting purposes with plotly? I can't find any online and all of my attempts in R have not worked. Any help would be appreciated

monfera · 2016-06-13T21:28:44Z

@bmcole I suppose you looked into the examples in the PR, but on the off chance not yet, just search for 'test' here, below the images: https://github.com/plotly/plotly.js/pull/419/files

bmcole · 2016-06-13T21:38:04Z

I found the test examples with json code, but am still unsure of how to
implement in R. here's my code that isn't working (it plots the order as
Friday, Monday, Saturday, Sunday, Thursday, Tuesday, Wednesday which is
undesired.

xform <- list(title = "Weekday",
               b = 150,
               tickangle=270,
               ticklen = 5,
               tickwidth = 2,
               categoryorder = "array",
               categoryarray = c("Sunday" , "Monday",

"Tuesday","Wednesday","Thursday", "Friday", "Saturday"))

yform <- list( title = "Number of Crimes",
               ticklen = 5,
               tickwidth = 2)

# line + scatter plot
plot_ly(weekdata, x = DayOfWeek, y = totalCrimes, type = "scatter",
        mode = "markers+lines", color = Category)  %>%

layout(xaxis=xform, yaxis=yform)

On Mon, Jun 13, 2016 at 5:28 PM, Robert Monfera notifications@github.com
wrote:

@bmcole https://github.com/bmcole I suppose you looked into the
examples in the PR, but on the off chance not yet, just search for 'test'
here, below the images: https://github.com/plotly/plotly.js/pull/419/files

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#419 (comment), or mute
the thread
https://github.com/notifications/unsubscribe/ANlA2U_rLgmFJLDwCc7mR6Xk6W7eUXyJks5qLcuSgaJpZM4IGL7W
.

monfera · 2016-06-13T21:47:49Z

@bmcole I wonder if it's a date type related mismatch. Have you had any success with simple (non-date) strings or e.g. integer values? I don't have R in front of me right now but it may be a thing to try.

etpinard · 2016-06-14T14:24:36Z

cc @cpsievert @timelyportfolio ⏫

cpsievert · 2016-06-14T15:23:59Z

@bmcole categoryorder was added in v1.10.2 of plotly.js and the R package is currently using v1.10.1. I'll update our plotly.js version ASAP.

monfera added 6 commits April 13, 2016 10:35

plotly#189 adding axis attributes to cartesian plots and gl3d plots

94e0133

plotly#189 category ordering - final, bisecting version

e36d163

plotly#189 categorymode defaults

df9ee94

plotly#189 putting categorymode, categorylist and coercion into use

eb499d4

plotly#189 jasmine tests

c7fb84b

plotly#189 image test mocks and baseline images

02ed858

monfera changed the title ~~189 Axis category ordering - squashed~~ Axis category ordering - adds feature #189 Apr 13, 2016

etpinard added feature something new status: reviewable labels Apr 13, 2016

etpinard reviewed Apr 13, 2016
View reviewed changes

plotly#189 PR feedback

53f12da

monfera added 2 commits April 15, 2016 16:00

plotly#189 Renaming attributes

14908d0

plotly#189 Renamings in image plot titles and image test filenames

b21ebb2

etpinard merged commit 4065112 into plotly:master Apr 18, 2016

etpinard mentioned this pull request Apr 25, 2016

Control categorical ordering from layout #189

Closed

etpinard mentioned this pull request May 4, 2016

Fix relayout axis category #510

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Axis category ordering - adds feature #189 #419

Axis category ordering - adds feature #189 #419

monfera commented Apr 13, 2016

etpinard Apr 13, 2016

cldougl Apr 13, 2016

etpinard Apr 13, 2016

mdtusz Apr 13, 2016

cldougl Apr 13, 2016

etpinard Apr 14, 2016

chriddyp Apr 14, 2016 •

edited

Loading

etpinard Apr 14, 2016

etpinard Apr 14, 2016

etpinard Apr 14, 2016 •

edited

Loading

etpinard commented Apr 13, 2016

etpinard commented Apr 14, 2016 •

edited

Loading

cldougl commented Apr 14, 2016

monfera commented Apr 15, 2016

etpinard commented Apr 18, 2016

bmcole commented Jun 13, 2016

monfera commented Jun 13, 2016

bmcole commented Jun 13, 2016

monfera commented Jun 13, 2016

etpinard commented Jun 14, 2016

cpsievert commented Jun 14, 2016 •

edited

Loading

Axis category ordering - adds feature #189 #419

Axis category ordering - adds feature #189 #419

Conversation

monfera commented Apr 13, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

chriddyp Apr 14, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

etpinard Apr 14, 2016 • edited Loading

Choose a reason for hiding this comment

etpinard commented Apr 13, 2016

etpinard commented Apr 14, 2016 • edited Loading

cldougl commented Apr 14, 2016

monfera commented Apr 15, 2016

etpinard commented Apr 18, 2016

bmcole commented Jun 13, 2016

monfera commented Jun 13, 2016

bmcole commented Jun 13, 2016

monfera commented Jun 13, 2016

etpinard commented Jun 14, 2016

cpsievert commented Jun 14, 2016 • edited Loading

chriddyp Apr 14, 2016 •

edited

Loading

etpinard Apr 14, 2016 •

edited

Loading

etpinard commented Apr 14, 2016 •

edited

Loading

cpsievert commented Jun 14, 2016 •

edited

Loading