Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribute minified files in own packages #4169

Merged

Conversation

cjwainwright
Copy link

The "dist" bundle packages (e.g. https://www.npmjs.com/package/plotly.js-dist) currently only include un-minified JavaScript. This PR is to create a separate package (e.g. plotly.js-dist-min) for each of the minified versions of the "dist" files.

@cjwainwright
Copy link
Author

@etpinard @archmoj Here are the changes as discussed. Thanks for the feedback :-)

@etpinard etpinard added this to the v1.50.0 milestone Sep 6, 2019
@cjwainwright
Copy link
Author

Argh, broken tests :-( Haven't got time to decipher that now. Will have to look another day.

@etpinard
Copy link
Contributor

etpinard commented Sep 6, 2019

image

You just need to remove a trailing white space.

@etpinard
Copy link
Contributor

etpinard commented Sep 6, 2019

Thanks very much. Merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature something new
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants