Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix toSVG for graphs that call Drawing.gradient #2914

Merged
merged 5 commits into from
Aug 16, 2018
Merged

Fix toSVG for graphs that call Drawing.gradient #2914

merged 5 commits into from
Aug 16, 2018

Commits on Aug 16, 2018

  1. add ability to run just 'jasmine' or just 'image' noci tests

    @etpinard
    etpinard committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    195cf19 View commit details
    Browse the repository at this point in the history

  2. replace fail -> failTest

    @etpinard
    etpinard committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    89fae05 View commit details
    Browse the repository at this point in the history

  3. fix toSVG for contour legend items & <linearGradient> colorbars

    @etpinard
    etpinard committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    b32aac0 View commit details
    Browse the repository at this point in the history

  4. set url to gradient definition as an 'attribute', not in 'style' 

    - so that we don't have to fiddle with quotes inside of quotes
  in Snapshot.toSVG
- clear corresponding 'style' setting to avoid potential conflicts
- adapt toSVG tests
    @etpinard
    etpinard committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    1c8017e View commit details
    Browse the repository at this point in the history

  5. Revert "set url to gradient definition as an 'attribute', not in 'sty… 

    …le'"

- see #2914 (comment)
  for more info.

This reverts commit 1c8017e.
    @etpinard
    etpinard committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    0557bb1 View commit details
    Browse the repository at this point in the history