Skip to content

Commit

Permalink
Remove unnecessary step from shapes.drawAll()
Browse files Browse the repository at this point in the history
* Removed call to `.remove()` in `shapes.drawAll()`, since `.remove()`
  is also call in `shapes.draw()`.

* No new test failed after this change.
  • Loading branch information
n-riesco committed Apr 6, 2016
1 parent c53303b commit f67ff4d
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion src/components/shapes/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,6 @@ function linearToData(ax) { return ax.type === 'category' ? ax.l2c : ax.l2d; }

shapes.drawAll = function(gd) {
var fullLayout = gd._fullLayout;
fullLayout._shapelayer.selectAll('path').remove();
for(var i = 0; i < fullLayout.shapes.length; i++) {
shapes.draw(gd, i);
}
Expand Down

0 comments on commit f67ff4d

Please sign in to comment.