only return label from the helper - set the label of dummy root to blank

plotly · Sep 28, 2019 · df5e121 · df5e121
1 parent 422d5d3
commit df5e121
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/src/traces/sunburst/calc.js b/src/traces/sunburst/calc.js
@@ -128,7 +128,8 @@ exports.calc = function(gd, trace) {
         cd.unshift({
             hasMultipleRoots: true,
             id: dummyId,
-            pid: ''
+            pid: '',
+            label: ''
         });
     }
 

diff --git a/src/traces/sunburst/helpers.js b/src/traces/sunburst/helpers.js
@@ -52,8 +52,7 @@ exports.getPtId = function(pt) {
 };
 
 exports.getPtLabel = function(pt) {
-    var label = pt.data.data.label;
-    return label === undefined ? pt.data.data.pid : label;
+    return pt.data.data.label;
 };
 
 exports.getValue = function(d) {

diff --git a/test/jasmine/tests/sunburst_test.js b/test/jasmine/tests/sunburst_test.js
@@ -235,7 +235,7 @@ describe('Test sunburst calc:', function() {
 
         expect(extract('id')).toEqual(['dummy', 'A', 'B', 'b']);
         expect(extract('pid')).toEqual(['', 'dummy', 'dummy', 'B']);
-        expect(extract('label')).toEqual([undefined, 'A', 'B', 'b']);
+        expect(extract('label')).toEqual(['', 'A', 'B', 'b']);
     });
 
     it('should compute hierarchy values', function() {

diff --git a/test/jasmine/tests/treemap_test.js b/test/jasmine/tests/treemap_test.js
@@ -346,7 +346,7 @@ describe('Test treemap calc:', function() {
 
         expect(extract('id')).toEqual(['dummy', 'A', 'B', 'b']);
         expect(extract('pid')).toEqual(['', 'dummy', 'dummy', 'B']);
-        expect(extract('label')).toEqual([undefined, 'A', 'B', 'b']);
+        expect(extract('label')).toEqual(['', 'A', 'B', 'b']);
     });
 
     it('should compute hierarchy values', function() {