Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1126] install module issue #1134

Merged
merged 2 commits into from
May 11, 2017

Conversation

xael-fry
Copy link
Member

@xael-fry xael-fry commented May 3, 2017

cf issue #1126

…loudfare protection on playframework.com

* rework the progress bar to display the size of module
@xael-fry xael-fry self-assigned this May 3, 2017
@xael-fry xael-fry added this to the 1.5.0 milestone May 3, 2017
@xael-fry xael-fry requested a review from asolntsev May 3, 2017 03:51
Copy link
Contributor

@asolntsev asolntsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xael-fry I don't imagine why this user agent should be default (DEFAULT_USER_AGENT = 'Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.7) Gecko/2009021910 Firefox/3.0.7'). But if are sure, I trust it. Let it be. :)

@xael-fry xael-fry merged commit 7ca2c15 into playframework:master May 11, 2017
@xael-fry xael-fry deleted the 1126_installModuleIssue branch August 17, 2017 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants