Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#2154] fix NPE on @On annotation #1219

Closed
flybyray opened this issue Feb 26, 2018 · 1 comment
Closed

[#2154] fix NPE on @On annotation #1219

flybyray opened this issue Feb 26, 2018 · 1 comment
Milestone
1.5.1

Comments

@flybyray
Copy link
Contributor

play1/framework/src/play/jobs/JobsPlugin.java

Line 195 in 2338f92

cron = Play.configuration.getProperty(cron);

evaluates to null, if there is no application configuration.

The @On annotation does not allow a default value which could be provided for getProperty. Therefore the default should be "".

Reason:

play1/framework/src/play/jobs/JobsPlugin.java

Line 197 in 2338f92

cron = Expression.evaluate(cron, cron).toString();

will throw a NPE if cron is null.
flybyray added a commit to flybyray/play1 that referenced this issue Feb 26, 2018
@flybyray
[#2154] Fixes NPE
f473f9a 
playframework#1219
@flybyray flybyray mentioned this issue Feb 26, 2018
Merged
@flybyray flybyray changed the title NPE [#2154] NPE Feb 26, 2018
xael-fry added a commit that referenced this issue Feb 28, 2018
@xael-fry
Merge pull request #1220 from flybyray/lighthouse-2154-patch
71874ce 
[#1219] Fixes NPE
[](https://play.lighthouseapp.com/projects/57987/tickets/2154)
@xael-fry
Copy link
Member

Merged #1220
Thanks

@xael-fry xael-fry added this to the 1.5.1 milestone Feb 28, 2018
@xael-fry xael-fry changed the title [#2154] NPE [#2154] fix NPE on @On annotation Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.5.1
Development

No branches or pull requests
2 participants
@flybyray @xael-fry