Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add getters to all Result subclasses #1056

Closed
asolntsev opened this issue Dec 26, 2016 · 1 comment
Closed

Add getters to all Result subclasses #1056

asolntsev opened this issue Dec 26, 2016 · 1 comment
Assignees
@asolntsev
Labels
has-pr improvement
Milestone
1.4.4

Comments

@asolntsev
Copy link
Contributor

We like "true" unit-tests.
We want to:

  1. call controller method from unit-test
  2. catch the result, like RenderTemplate or Redirect
  3. Verify arguments of RenderTemplate or url of Redirect.

To do it, we need to add public getters to all Result subclasses.
@asolntsev asolntsev self-assigned this Dec 26, 2016
asolntsev added a commit to codeborne/play that referenced this issue Dec 26, 2016
@asolntsev
playframework#1056 fix code formatting
8c6b540
asolntsev added a commit to codeborne/play that referenced this issue Dec 26, 2016
@asolntsev
playframework#1056 add getters to all Result subclasses
8c942da 
so we can catch them in unit-tests and verify al parameters
asolntsev added a commit to codeborne/play that referenced this issue Dec 26, 2016
@asolntsev
playframework#1056 refactor class RenderBinary
a73b598 
split long method apply() to many small methods with readable names
@asolntsev asolntsev mentioned this issue Dec 26, 2016
Merged
@asolntsev
Copy link
Contributor Author

Issue has been resolved with PR #1057

@xael-fry xael-fry added this to the 1.4.4 milestone Dec 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asolntsev asolntsev

Labels
has-pr improvement
Projects
None yet
Milestone
1.4.4
Development

No branches or pull requests
2 participants
@asolntsev @xael-fry