add support for 404 error pages tracking #6 #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #6
This PR also includes support for #4 and #3. But, I will test those issues with
develop
branch again and then will update accordingly.Visuals
@metmarkosaric I assume that we should keep 404 tracking functionality enabled by default so I have not provided any admin settings to disable it as tracking custom events and 404 will be essential need these days. But, I have provided a WP filter to disable it.
Can you please review the PR and merge if it looks good?
Suggestion
@metmarkosaric I have a suggestion that if we include some default goals whenever a user add a site on plausible.io then it will be plug'n'play functionality for users using the plugin. See screenshot for what screen I am talking about.
For example, 404 goal will be automatically added when we add a site. So, installing this plugin will be enough without any configuration.
What do you think?