Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve settings page to future proof new settings #26 #51

Merged
merged 49 commits into from
Sep 29, 2021
Merged

Conversation

mehul0810
Copy link
Contributor

This PR closes #26 and #11

Description

I have worked on a couple of issues as a part of this issue:

  • Simplified the admin settings field API and storing of data
  • Added support for tracking analytics based on user roles
  • improved UI

Screenshots

CleanShot 2021-09-29 at 01 10 19@2x

@metmarkosaric
Copy link
Collaborator

it's looking good @mehul0810, thanks!

@mehul0810 mehul0810 merged commit 49eead0 into develop Sep 29, 2021
@mehul0810 mehul0810 deleted the issue/26 branch September 29, 2021 09:01
@mehul0810
Copy link
Contributor Author

Thanks for the review @metmarkosaric

I have merged this PR 🎉

@lumpysimon
Copy link

Do you have an estimated date for the next release? I'd love to exclude editors from tracking, but I see this has been approved for over a year, so I wonder if there's a reason it's not been released?

I've just moved five clients to Plausible from Google, and as they all use the Editor role daily this would be really great to improve the accuracy of their stats.

Thanks :)

@metmarkosaric
Copy link
Collaborator

@lumpysimon we don't have any estimated date at the moment unfortunately. we're in the final stages of testing the next release but this version is focused on introducing the proxy by default (and removing the custom domain feature) in the plugin. this is a major undertaking that has taken a lot of development time. after this major version is released, we plan to review some of the other new additions such as the ability to exclude editors too so these would make it in the version after next. thanks for your patience and do stay tuned!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve settings page to future proof new settings
3 participants