Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't render empty list element in CE #4596

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Don't render empty list element in CE #4596

merged 1 commit into from
Sep 19, 2024

Conversation

ruslandoga
Copy link
Contributor

@ruslandoga ruslandoga commented Sep 19, 2024 •
edited
Loading

Changes

Fixes #4459 (comment) in CE.

Tests

  • This PR does not require tests

Changelog

  • This PR does not make a user-facing change

Documentation

  • This change does not need a documentation update

Dark mode

  • The UI has been tested both in dark and light mode
Screenshot 2024-09-19 at 13 23 01 Screenshot 2024-09-19 at 13 23 15

@ruslandoga ruslandoga mentioned this pull request Sep 19, 2024
Draft
4 tasks
@ruslandoga ruslandoga added the self-hosting Anything self-hosted label Sep 19, 2024
zoldar
zoldar approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@zoldar zoldar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@ruslandoga ruslandoga added this pull request to the merge queue Sep 19, 2024
Merged via the queue into plausible:master with commit 5766478 Sep 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zoldar zoldar zoldar approved these changes

@aerosol aerosol Awaiting requested review from aerosol

Assignees
No one assigned
Labels
self-hosting Anything self-hosted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruslandoga @zoldar