Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add email configuration #774

Open
lsmith77 opened this issue Apr 22, 2024 · 1 comment · May be fixed by #776
Open

add email configuration #774

lsmith77 opened this issue Apr 22, 2024 · 1 comment · May be fixed by #776

Comments

@lsmith77
Copy link

lsmith77 commented Apr 22, 2024

What in this template can be improved or added as a feature?

Currently the settings.py is missing settings for email:
https://docs.djangoproject.com/en/4.0/topics/email/

What exactly should be updated?

EMAIL_HOST = os.getenv("PLATFORM_SMTP_HOST")
EMAIL_PORT = os.getenv("PLATFORM_SMTP_PORT", 25)

How important is this feature to you?

Not a blocker

Additional context

No response

@gilzow
Copy link
Contributor

gilzow commented Apr 22, 2024

PLATFORM_SMTP_HOST is only available if outgoing email has been enabled for the environment.

PLATFORM_SMTP_PORT isn't a Platform.sh/Upsun provided environment variable.

As such, my PR only sets EMAIL_HOST and EMAIL_PORT if the PLATFORM_SMTP_HOST is available. I've also gone ahead and set EMAIL_PORT to a static value of 25.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants