Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix /tmp dir remove #361

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Conversation

devidask27
Copy link
Contributor

ISSUE(S):

SUMMARY

instead of removing everything from /tmp dir removing only pf9 related files.

ISSUE TYPE

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that may cause existing functionality to not work as expected)
  • This change requires a documentation update

IMPACTED FEATURES/COMPONENTS:

decommission-node command

TESTING DONE

Automated

Manual

Tested deletion of files in /tmpdir

root@test-pf9-bare-os-u20-3047764-360-3:~# ls /tmp
authbs-certs.D1nx  authbs-certs.batS  python-eggs       systemd-private-4f27b759b54f40a083412d954c4532fd-ntp.service-MCVhxg
authbs-certs.EP8m  authbs-certs.hzHZ  snap-private-tmp  systemd-private-4f27b759b54f40a083412d954c4532fd-systemd-logind.service-N6ALyf
authbs-certs.aEVW  authbs-certs.sllg  snap.lxd          systemd-private-4f27b759b54f40a083412d954c4532fd-systemd-resolved.service-yMlLtf
root@test-pf9-bare-os-u20-3047764-360-3:~# 
root@test-pf9-bare-os-u20-3047764-360-3:~# 
root@test-pf9-bare-os-u20-3047764-360-3:~# pf9ctl decommission-node
New version found. Please upgrade to the latest version
✓ Loaded Config Successfully
Node is not connected to any cluster
Deauthorized node from UI
Removing pf9-hostagent (this might take a few minutes...)
Removed hostagent
Removing logs...
Running clean all
Removing pf9 HOME dir
Node decommissioning started....This may take a few minutes....Check the latest status in UI
root@test-pf9-bare-os-u20-3047764-360-3:~# 
root@test-pf9-bare-os-u20-3047764-360-3:~# 
root@test-pf9-bare-os-u20-3047764-360-3:~# ls /tmp
snap-private-tmp  systemd-private-4f27b759b54f40a083412d954c4532fd-fwupd.service-1Q31vj  systemd-private-4f27b759b54f40a083412d954c4532fd-systemd-logind.service-N6ALyf
snap.lxd          systemd-private-4f27b759b54f40a083412d954c4532fd-ntp.service-MCVhxg    systemd-private-4f27b759b54f40a083412d954c4532fd-systemd-resolved.service-yMlLtf
root@test-pf9-bare-os-u20-3047764-360-3:~#

Reviewers

Copy link
Contributor

@psarwate psarwate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@devidask27 devidask27 merged commit c009fe3 into master Nov 22, 2023
2 checks passed
@devidask27 devidask27 deleted the private/master/devidas/tmp-clean-fix branch November 22, 2023 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants