Add project paths command to LF #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniil Kouznetsov <dkouznetsov@pivotal.io>
Signed-off-by: Daniil Kouznetsov <dkouznetsov@pivotal.io>
mainej
reviewed
May 31, 2018
lib/license_finder/project_finder.rb
Outdated
| @@ -41,7 +42,7 @@ def project_root?(pathname) | |||
|
|
|||
| def active_project?(project_path) | |||
| active_project = @package_managers.map do |pm| | |||
| pm.new(project_path: project_path).active? | |||
| pm.new(project_path: project_path).active? unless pm == GoWorkspace && @configurable | |||
There was a problem hiding this comment.
Why the break in polymorphism? That is, why not pass @configurable to pm.new, and let GoWorkspace do something with it?
A related problem is that the name @configurable doesn't imply what it will be used for. Instead, maybe you could add an argument (possibly exposed at the CLI) which says which types of project managers to skip.
Signed-off-by: Daniil Kouznetsov <dkouznetsov@pivotal.io>
features/features/cli/cli_spec.rb
Outdated
| @@ -98,4 +98,30 @@ | |||
| expect(developer).to_not be_seeing('MIT') | |||
| end | |||
| end | |||
|
|
|||
| context 'running project_roots', :focus do | |||
features/features/cli/cli_spec.rb
Outdated
| @@ -98,4 +98,30 @@ | |||
| expect(developer).to_not be_seeing('MIT') | |||
| end | |||
| end | |||
|
|
|||
| context 'running project_roots', :focus do | |||
There was a problem hiding this comment.
can you update this to a describe?
lib/license_finder/cli/main.rb
Outdated
| @@ -158,11 +164,12 @@ def check_valid_project_path | |||
| raise "Project path '#{config.project_path}' does not exist!" unless config.valid_project_path? | |||
| end | |||
|
|
|||
| def aggregate_paths | |||
| def aggregate_paths(strict_matching = false) | |||
There was a problem hiding this comment.
Can we use the config to do this instead? That way we avoid having a parameter on this method just to pass it to the project finder.
Signed-off-by: Yoon Jean Kim <ykim@pivotal.io>
xtreme-lisheng-tai
force-pushed
the
project_paths
branch
from
7f8841f
to
7792f91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniil Kouznetsov dkouznetsov@pivotal.io