Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optimizing sigmoid function #989

Merged
merged 1 commit into from
Nov 1, 2016
Merged

optimizing sigmoid function #989

merged 1 commit into from
Nov 1, 2016

Conversation

markroxor
Copy link
Contributor

Optimising sigmoid function created in PR #895.

@tmylk tmylk merged commit 6ccebf0 into piskvorky:develop Nov 1, 2016
@@ -300,7 +295,7 @@ def train_cbow_pair(model, word, input_word_indices, l1, alpha, learn_vectors=Tr
if w != word.index:
word_indices.append(w)
l2b = model.syn1neg[word_indices] # 2d matrix, k+1 x layer1_size
fb = sigmoid(dot(l1, l2b.T)) # propagate hidden -> output
fb = expit(dot(l1, l2b.T)) # propagate hidden -> output
Copy link
Owner

@piskvorky piskvorky Nov 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the only place where inverse logit (expit) is used? Probably worth updating all occurrences, consistently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants