Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LdaMallet Fixes #771

Merged
merged 3 commits into from
Jul 5, 2016
Merged

LdaMallet Fixes #771

merged 3 commits into from
Jul 5, 2016

Conversation

bhargavvader
Copy link
Contributor

This is with respect to #767 .

I removed the unnecessary log mentioning the variable assignment, and tried to add an alias by doing self.word_topics = self.wordtopics = self.load_word_topics().
Is that correct?

I also changed occurrences of topn to num_words to keep it consistent throughout. #755 already did this, but left print_topic and show_topic untouched. It doesn't cause any problems but I thought I'd make it the same throughout.

@tmylk , @piskvorky , please review.

@piskvorky
Copy link
Owner

Looks good to me... except still needs a comment explaining why the alias is there.

And maybe a mention in the changelog, so we can deprecate the old name, gradually.

@bhargavvader
Copy link
Contributor Author

Added comment, made change in changelog.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants