Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use gensim.test.utils datapath() to construct paths to the test data #3297

Merged
merged 1 commit into from
Apr 15, 2022
Merged

Use gensim.test.utils datapath() to construct paths to the test data #3297

merged 1 commit into from
Apr 15, 2022

Conversation

pabs3
Copy link
Contributor

@pabs3 pabs3 commented Feb 26, 2022

Makes the code more readable and consistent with other tests.

piskvorky
piskvorky approved these changes Feb 26, 2022
View reviewed changes
Copy link
Owner

@piskvorky piskvorky left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much! Is the CI failure related?

@piskvorky piskvorky added this to the Next release milestone Mar 20, 2022
@pabs3 pabs3 force-pushed the use-datapath branch 2 times, most recently from 63e31a7 to ead2afa Compare April 2, 2022 06:15
@pabs3
Use gensim.test.utils datapath() to construct paths to the test data
168a9ef 
Makes the code more readable and consistent with other tests.
@pabs3
Copy link
Contributor Author

pabs3 commented Apr 2, 2022

Fixed the flake8 complaint by dropping the os.path import.

piskvorky
piskvorky approved these changes Apr 2, 2022
View reviewed changes
Copy link
Owner

@piskvorky piskvorky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love these little clean ups and tidying up, much appreciated @pabs3 !

@piskvorky piskvorky merged commit 317e447 into piskvorky:develop Apr 15, 2022
@piskvorky
Copy link
Owner

Merged. Thank you!

@pabs3 pabs3 deleted the use-datapath branch May 4, 2022 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piskvorky piskvorky piskvorky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@pabs3 @piskvorky