Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly install Pattern library for documentation build #2626

Merged
merged 3 commits into from
Oct 8, 2019
Merged

Properly install Pattern library for documentation build #2626

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cba1a49
Probably fixes #2534
Hiyorimi Oct 7, 2019
96eb7fc
Uppercase P
Hiyorimi Oct 7, 2019
8ce4947
Added comment
Hiyorimi Oct 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,13 +276,14 @@ def finalize_options(self):
])

if (3, 0) < sys.version_info < (3, 7):
linux_testenv.extend(['nmslib'])
linux_testenv.extend(['nmslib'])

docs_testenv = linux_testenv + distributed_env + [
'sphinx',
'sphinxcontrib-napoleon',
'plotly',
'pattern <= 2.6',
# Pattern's version is specified to install Pattern 3.6, which adds python3 support
'Pattern >= 3.6',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why we need to specify the version here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To get version with python3 support.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please mention that in a code comment? Someone is likely to ask the same question later on.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed

'sphinxcontrib.programoutput',
]
#
Expand Down Expand Up @@ -360,7 +361,7 @@ def finalize_options(self):

url='http://radimrehurek.com/gensim',
download_url='http://pypi.python.org/pypi/gensim',

license='LGPLv2.1',

keywords='Singular Value Decomposition, SVD, Latent Semantic Indexing, '
Expand Down