Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Pivot Normalization for
gensim.models.TfidfModel
. Fix #220 #1780Add Pivot Normalization for
gensim.models.TfidfModel
. Fix #220 #1780Changes from 55 commits
efb7e3c
b7d07d4
e8a3f16
648bf21
a6f1afb
d091138
951c549
40c0558
b35344c
634d595
0917e75
bef79cc
d3d431c
0e6f21e
7ee7560
b2def84
5b2d37a
ac4b154
0bacc08
51e0eb9
3039732
99e6a6f
7d63d9c
e5140f8
4afbadd
d2fe235
5565c78
099dbdf
ef67f63
52ee3c4
3087030
62bba1b
0a9f816
dc63ab9
035c8c5
dc4ca52
1ee449d
4ea6caa
b3cead6
044332b
1c2196c
309b4e8
3866a9c
12b42e6
0ff6ad7
65c651b
4a947ba
619bb33
f105190
6410f21
2eb6fc2
a65dccf
8717350
95cb630
5f46d2f
2c7115d
1fe46f8
63c8385
5e87229
9f2b02c
fc701a1
1868da5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A strange description, better
vector length
maybe (here and everywhere)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed docstring for new parameters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use
Some text <http://...>
_ references (instead of[123]_
), for all references in this file. This will be needed for serious change in documentation building that happens very soon.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can confuse users, need to mention that works only if
pivot
set.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot, what's about
slope
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we used
140 characters
limit -> no need to split this line here