Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PP: More message types #14

Closed
NotAFile opened this issue Feb 12, 2018 · 4 comments
Closed

PP: More message types #14

NotAFile opened this issue Feb 12, 2018 · 4 comments

Comments

@NotAFile
Copy link
Member

NotAFile commented Feb 12, 2018

The protocol currently defines three message types:

Value Type
0 CHAT_ALL
1 CHAT_TEAM
2 CHAT_SYSTEM

1.x expands this with

Value Type
0 CHAT_ALL
1 CHAT_TEAM
2 CHAT_SYSTEM
3 CHAT_BIG (displayed on the center of the screen)

In addition, OpenSpades defines:

Prefix Meaning
N%: Displays a "Notice" alert.
!%: Displays a "Error" alert accompanied with a sound.
%%: Displays a "Warning" alert accompanied with a sound.
C%: Displays a center-aligned large message.

The prefixes are kind of ugly, so I propose the following extension:

Value Type
0 CHAT_ALL
1 CHAT_TEAM
2 CHAT_SYSTEM
3 CHAT_BIG (displayed on the center of the screen)
4 CHAT_INFO (displays a notice)
5 CHAT_WARNING (displays a warning)
5 CHAT_ERROR (displays a error)

Concerns:

  • old clients might not support this. This can be easily solved with server-side version checking.
@xtreme8000
Copy link
Contributor

Could you provide examples on how these new types should be displayed on screen?

@NotAFile
Copy link
Member Author

I think that is up to the individual implementation. There's really no good way to standardize it, it has to fit with each games look and feel.

In OpenSpades, the following is used:

BIG: displayed in the upper half in large letters, usually message about the game state. E.g. X has captured the intel, You were killed by X.

INFO, WARNING, ERROR: Small popup box in the bottom half. Info has a black border, warning a yellow border + icon, error a red border + icon

@xtreme8000
Copy link
Contributor

Maybe this could work like #15 (comment) too?

xtreme8000 added a commit to xtreme8000/BetterSpades that referenced this issue Mar 13, 2019
* align camera hitscan distance to player body part height
* Add force_displaylist option to settings
* correct grenade rotation animation
* smooth out player orientation interpolation more
* allow to grab block color from other players
* spawn particles when hitting the lowest block layer
* add message types extension, see
piqueserver/aosprotocol#14
@xtreme8000
Copy link
Contributor

xtreme8000 commented Apr 4, 2019

assigned extID 0xC1 (193, packetless), version 1 in BetterSpades

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants