ECM crime - Don't use your ECM near a station #5916
Conversation
Always wise to have some distance in situations of discharge.... I do believe the new equipment system aims to add a arm/disarm for weapons, but I could be wrong. Would be good to have for ECM as well. |
There was a problem hiding this comment.
Given that you're hesitant about submitting it, I'd suggest that this PR should probably sit and receive a bit more thought before it's merged. The actual implementation of the ECM event is a bit misleading from the perspective of the LuaAPI - at minimum, I'd like to see the name of the event changed to more clearly indicate which situations it triggers in before I can sign off on the PR.
The ECM equipment / game system itself will also hopefully be receiving some design thought as we move towards Stage 2 / Stage 3 of the EquipSet rework. Feel free to contribute in that respect as well - the implementation of this PR may need to adjust to take into account some of the interactions of the new equipment system as we iteratively implement it.
| } | ||
| } | ||
| else if (body->IsType(ObjectType::SPACESTATION)) { |
There was a problem hiding this comment.
I'm a little hesitant about this check here and the associated event naming. This seems a bit brittle, and the onUseECM name doesn't really match what's happening here.
I hesitated a bit to submit this because of the overly harsh reaction if you happen to press the ecm button while taking off, but this is the same for all crime, dumping waste or firing a weapon. You will be terminated. I also think there could be some more around this like a couple of the lights going out on the platform or the BBS being out of order the next time you land there. ECM should be used responsibly.