Repopulate BBS if empty #5894
Merged
Repopulate BBS if empty #5894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an infrequent issue where the BBS will show up empty on a game reload as SpaceStation.adverts[station] is missing. This fix will cause the BBS to repopulate itself but only from those modules that impements onUpdateBB(). It will not solve the underlying cause. Addresses pioneerspacesim#5886
|
In a way, this would mask the bug, possibly making it harder to find the root cause. |
Maybe, but the station repairs itself this way. I think it's worth a try. There should probably be some tests in the code to track what's going on. Does the save or the reload fail? |
Web-eWorks
approved these changes
Aug 23, 2024
zonkmachine
added a commit
to zonkmachine/pioneer
that referenced
this pull request
Aug 30, 2024
This is a fixup from pioneerspacesim#5894 / a005ad4 Instead of updating the BBS it should be created if SpaceStation.adverts[station] is missing.
Merged
zonkmachine
added a commit
to zonkmachine/pioneer
that referenced
this pull request
Sep 1, 2024
This is a fixup from pioneerspacesim#5894 / a005ad4 Instead of updating the BBS it should be created if SpaceStation.adverts[station] is missing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an infrequent issue where the BBS will show up empty on a game reload as SpaceStation.adverts[station] is missing. This fix will cause the BBS to repopulate itself but only from those modules that impements onUpdateBB(). It will not solve the underlying cause.
Addresses #5886