Update libfmt, fix compilation warnings and invalid JSON CustomSystem position #5759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- No non-void-pointer automatic formatting - const unsigned char* is not implicitly convertible to const char* - Enums have to be manually cast to int or a formatter provided for them
- Because UndoClosure overrides the Swap() virtual method, Swap() cannot be called inside the constructor - Instead, call it in the helper function which pushed the undo step
- Address unused variable, integer signedness comparison, and initialization order issues.
- %b is not a format specifier recognized by fmt - Use Log::Info instead of the printf overloads
- core.h is the "lightweight" API for libfmt - Other than printf.h, we don't use any of format.h's features
- Missing transitive includes after fmt upgrade - GCC 14 doesn't pull in <algorithm> for Input.h anymore
Web-eWorks
force-pushed
the
new-year-new-deps
branch
from
10c94b0
to
e861c22
Compare
- Validates that the compiler correctly obeys the C++17 standard regarding sequence points in a braced-init-list - Ensures multiple-push / multiple-pull functionality works correctly
|
This PR also introduces a new test case addressing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Been sitting on this PR for longer than I intended, life got busy.
Essentially does what it says on the tin, updates libfmt to v10.2.1 (fixes #5693) and fixes a few sets of compilation warnings while in the area.
I've found and fixed a bug that was causing JSON custom systems to lose their position values (more correctly, the position was initialized from the sector index instead, which could cause all kinds of bugs) - it's benign at the moment since we don't ship any JSON custom systems other than Sol with a
{0,0,0}sector index and position.This also bumps our CI build version to
20240203-devfollowing the schema we've set up - this PR was intended to be opened immediately after the release / that commit pushed directly to master, but my attention has been unfortunately elsewhere.