Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small pre-release QOL fixes #5326

Merged
merged 4 commits into from
Jan 22, 2022
Merged

Conversation

Web-eWorks
Copy link
Member

@Web-eWorks Web-eWorks commented Jan 21, 2022

Yet another "microfixes" PR in a long tradition of the same, it does what it says on the tin. Going to leave this open for a little bit to collate small QOL fixes I find.

@impaktor
Copy link
Member

QOL = "Quantity of Lines"?

@Web-eWorks
Copy link
Member Author

Quality of Life actually, if you want Quantity of Lines then you'll have to wait until the next ImGui upgrade PR... 😄

@Gliese852
Copy link
Contributor

Gliese852 commented Jan 21, 2022

Still getting
contrib/imgui/imgui.cpp:6635: bool ImGui::IsWindowHovered(ImGuiHoveredFlags): Assertion '(flags & ImGuiHoveredFlags_AllowWhenOverlapped) == 0' failed. when I launch the game, and
contrib/imgui/imgui.cpp:7075: void ImGui::PopID(): Assertion window->IDStack.Size > 1' failed` when I click the 'personal information' button
EDIT: oh, in fact, I wanted to write this in #5327, but it would probably be even more appropriate to add a fix for this here

@Web-eWorks
Copy link
Member Author

Still getting contrib/imgui/imgui.cpp:6635: bool ImGui::IsWindowHovered(ImGuiHoveredFlags): Assertion '(flags & ImGuiHoveredFlags_AllowWhenOverlapped) == 0' failed. when I launch the game, and contrib/imgui/imgui.cpp:7075: void ImGui::PopID(): Assertion window->IDStack.Size > 1' failed` when I click the 'personal information' button EDIT: oh, in fact, I wanted to write this in #5327, but it would probably be even more appropriate to add a fix for this here

Thanks! I wasn't sure if you were wanting to fix that in your branch or not, but I can fix that here pretty quickly.

@bszlrd bszlrd linked an issue Jan 22, 2022 that may be closed by this pull request
@Web-eWorks Web-eWorks merged commit 799578f into pioneerspacesim:master Jan 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants